Fix bad stringification of negative years#3
Open
LouisStrous wants to merge 2 commits intodagolden:masterfrom
Open
Fix bad stringification of negative years#3LouisStrous wants to merge 2 commits intodagolden:masterfrom
LouisStrous wants to merge 2 commits intodagolden:masterfrom
Conversation
added 2 commits
October 11, 2025 22:02
with a minus sign and at least 4 digits for the year, e.g. '-0003-02-28'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dates with negative years are stringified incorrectly because their print format (%u) interprets the values as unsigned integers. I added a module test to detect the problem, and a fix for the problem.